IDP 3.4.2 attribute-resolver.xml SourceAttribute deprecation log warning

[Peter Schober]

* Losen, Stephen C (scl) <scl at virginia.edu> [2018-12-20 13:16]:
> WARN [DEPRECATED:118] - XML Element 'SourceAttribute', (file
> [/opt/shibboleth-idp/conf/attribute-resolver.xml]): This will be
> removed in the next major version of this software; replacement is
> by using <InputAttributeDefinition> and <InputDataConnector>

FWIW, my IDP updated to 3.4.2 runs the Template attr definition in the
example "displayName, alternative 2: create from givenName and sn" at
https://wiki.univie.ac.at/display/federation/IDP+3+Attribute+resolution#IDP3Attributeresolution-displayName
verbatim and I don't have any WARNs and no DEPRECATED lines in the
log.

> So I went to the IDP wiki and the documentation for the Template
> AttributeDefinition looks like it needs work.  It documents
> SourceAttribute without mentioning it is deprecated.  Also the
> example has this somewhat misleading element
> 
> <InputAttributeDefinition ref="myLdap" />
> 
> I suspect this should be
> 
> <InputDataConnector ref="myLdap" attributeNames="attrFromLdap" />

Well, the example names might be misinterpreted, it might as well
depend on attributes defined elsewhere in the resolver so an
InputAttributeDefinition is fine.
Feel free to add another example you find more expressive, including
my own above.

> And I suspect that the two <SourceAttribute> elements should be removed.

A quick test seems to indicate that at least my example works with and
without those lines? No warning, though, also with the elements there.

So is this a case of "the config is not what you think it is"?

-peter