IDP 3.4.2 attribute-resolver.xml SourceAttribute deprecation log warning

[Losen, Stephen C (scl)]

Hi folks,

I upgraded my IDP from 3.4.1 to 3.4.2 and got this WARN message in the logs:

WARN [DEPRECATED:118] - XML Element 'SourceAttribute', (file [/opt/shibboleth-idp/conf/attribute-resolver.xml]): This will be removed in the next major version of this software; replacement is by using <InputAttributeDefinition> and <InputDataConnector>

Indeed I had this Template AttributeDefinition:

<AttributeDefinition xsi:type="Template" id="givenSurname">
    <InputAttributeDefinition ref="givenName" />
    <InputAttributeDefinition ref="surname" />
    <AttributeEncoder xsi:type="SAML1String" name="urn:mace:dir:attribute-def:givenName" encodeType="false" />
    <AttributeEncoder xsi:type="SAML2String" name="urn:oid:2.5.4.42" friendlyName="givenName" encodeType="false" />
    <Template>${givenName} ${surname}</Template>
    <SourceAttribute>givenName</SourceAttribute>
    <SourceAttribute>surname</SourceAttribute>
</AttributeDefinition>

So I removed the two <SourceAttribute> lines.  I restarted the IDP (restarted Jetty), no XML syntax or schema errors, but I still get the DEPRECATED message for attribute-resolver.xml which now has no SourceAttribute elements whatsoever.  Spurious warning?

So I went to the IDP wiki and the documentation for the Template AttributeDefinition looks like it needs work.  It documents SourceAttribute without mentioning it is deprecated.  Also the example has this somewhat misleading element

<InputAttributeDefinition ref="myLdap" />

I suspect this should be

<InputDataConnector ref="myLdap" attributeNames="attrFromLdap" />

And I suspect that the two <SourceAttribute> elements should be removed.

Stephen C. Losen
ITS - Systems and Storage
University of Virginia
scl at virginia.edu    434-924-0640