Wrong error Template for Metadata errors

[Cantor, Scott]

On 1/4/17, 8:14 AM, "users on behalf of Enno Gröper" <users-bounces at shibboleth.net on behalf of enno.groeper at cms.hu-berlin.de> wrote:

> Any ideas why this is happening?

You don't have a property named metadata in your request settings or the <Errors> element, so it's not finding a hit and falling back to the default behavior. There's a small bug such that when there's nothing in the configuration at all, the final defaulting of the template name doesn't make the mderror check.

>    Did this happen to anyone else before?

If anybody had reported the bug it would have been fixed.

> I can't find a configuration issue nor a code bug on first sight. But 
> because there is not much config in this area, I would assume it's a bug.

Since you're looking at the code, the bug is here:

        // If there's still no template to use, just use pageError.html unless it's an access issue.
        string fname;
        if (!pathname.first) {
            if (!accesserror) {
                fname = string(page) + "Error.html";
                pathname.second = fname.c_str();
            }
        }
        else {
            fname = pathname.second;
        } 

There's no check for the mderror boolean, and so it doesn't default to using "metadata" as the page name in that final bit of code.

If you file it, it will certainly get fixed.

-- Scott