Wrong error Template for Metadata errors

[Enno Gröper]

Hi,

I'm using libapache2-mod-shib2 version 2.5.2+dfsg-2 (Ubuntu trusty) and 
just tested blacklisting an IdP.
To my knowledge the resulting error page should use metadataError.html 
template, but uses the generic sessionError.html instead.

In shibsp/ServiceProvider.cpp there is the following code:

long SHIBSP_DLLLOCAL sendError(
         Category& log, SPRequest& request, const Application* app, 
const char* page, TemplateParameters& tp, bool mayRedirect=true
         )
     {
         // The properties we need can be set in the RequestMap, or the 
Errors element.
         bool mderror = dynamic_cast<const 
opensaml::saml2md::MetadataException*>(tp.getRichException())!=nullptr;

[...]

if (mderror)
                 pathname = settings.first->getString("metadataError");


My error page looks like this:

=============

opensaml::saml2md::MetadataException

The system encountered an error at Wed Jan 4 10:12:45 2017

To report this problem, please contact the site administrator at 
<contact-address>.

Please include the following message in any email:

opensaml::saml2md::MetadataException at 
(https://<mysp>/Shibboleth.sso/Login)

Unable to locate metadata for identity provider (https://<blocked 
idp>/idp/shibboleth)

=============

My Errors config form shibboleth2.xml looks like this:

<Errors supportContact="<contact-address>"
             helpLocation="/about.html"
             styleSheet="/shibboleth-sp/main.css"/>


Any ideas why this is happening?
Did this happen to anyone else before?
I can't find a configuration issue nor a code bug on first sight. But 
because there is not much config in this area, I would assume it's a bug.


Thanks for reading & happy new year!
Enno