PropertiesWithComments and newlines ?

[Tom Zeller]

Rod,

So … what do you think about PropertiesWithComments supporting a single property which spans multiple lines ?

The idp.additionalProperties property in conf/idp.properties was recently changed[1] to span multiple lines, and some integration tests are failing because I use PropertiesWithComments to mung idp.properties, which ends up looking like :

 idp.additionalProperties= 
 /conf/ldap.properties,= 
 /conf/saml-nameid.properties,= 
 /conf/services.properties,= 
 /conf/authn/duo.properties=

instead of

 idp.additionalProperties = \
 /conf/ldap.properties, \
 /conf/saml-nameid.properties, \
 /conf/services.properties, \
 /conf/authn/duo.properties

I can create an issue, but I thought we should probably discuss first. We can also revert the change, but I thought PropertiesWithComments is used during installation.

[1] http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-conf/src/main/resources/conf/idp.properties?r1=8308&r2=8307&pathrev=8308

Tom