A couple of TODOs in the attributes code.

[Cantor, Scott]

On 10/21/14, 4:44 PM, "Daniel Fisher" <dfisher at vt.edu> wrote:
>
>You're correct. That didn't get ported correctly, but it leads me to
>another question. In v2, the LDAPDataConnector always returned a single
>LDAP entry. A deployer would use the mergeResults option if they needed
>attributes from multiple entries. The change
> in r6746 always merges all the attributes from all entries, so I don't
>think that option is needed anymore. No idea if anyone was relying on
>this as a negative feature, if so we may want a switch to disable merging
>of results.

It seemed like my change essentially as a merge, that's why I wondered.

I should have checked, I assumed the old one supported multiple entries
since the other connector had. I would say we just make my change
conditional using the option and make it the same as before, but it's a
little more than that because the option needs to be seen by the
MappingStrategy, I think.

Maybe it should be migrated to an option on the interface you did for the
LDAP-based MappingStrategy classes, and then implemented on the String one
to conditionalize what I changed.

-- Scott