A couple of TODOs in the attributes code.

[Daniel Fisher]

On Tue, Oct 21, 2014 at 10:37 AM, Cantor, Scott <cantor.2 at osu.edu> wrote:

> I had a concern about whether the mergeResults option in LDAP is making
> sense. When I read the docs on that option in the schema, I couldn't map
> that to what the Javadoc for the ldaptive class that it apparently
> triggers the use of was saying. They didn't seem quite the same to me.
>

You're correct. That didn't get ported correctly, but it leads me to
another question. In v2, the LDAPDataConnector always returned a single
LDAP entry. A deployer would use the mergeResults option if they needed
attributes from multiple entries. The change in r6746 always merges all the
attributes from all entries, so I don't think that option is needed
anymore. No idea if anyone was relying on this as a negative feature, if so
we may want a switch to disable merging of results.

Sorry if that doesn't make sense, I've had a lot of NyQuil the past few
days...

--Daniel Fisher
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://shibboleth.net/pipermail/dev/attachments/20141021/2e339408/attachment.html