[JIRA] (JSSH-9) Rework IdentifierGenerationStrategy usage

[Scott Cantor (Jira)]

Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) *commented* on JSSH-9 ( https://shibboleth.atlassian.net/browse/JSSH-9?atlOrigin=eyJpIjoiYjQ4YjZhZjJiMjQ5NGQ2MDk4YjdjYThmZGVjZGI2YTUiLCJwIjoiaiJ9 )

Re: Rework IdentifierGenerationStrategy usage ( https://shibboleth.atlassian.net/browse/JSSH-9?atlOrigin=eyJpIjoiYjQ4YjZhZjJiMjQ5NGQ2MDk4YjdjYThmZGVjZGI2YTUiLCJwIjoiaiJ9 )

I think my concrete suggestions are:

* Ensure anything instantiating these directly is given a setter for installing an alternative implementation (as many of our IdP classes do)
* Add static factory methods to the interface or some other class to actually instantiate the specific implementations we supply so classes up above don’t directly create them.

( https://shibboleth.atlassian.net/browse/JSSH-9#add-comment?atlOrigin=eyJpIjoiYjQ4YjZhZjJiMjQ5NGQ2MDk4YjdjYThmZGVjZGI2YTUiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JSSH-9#add-comment?atlOrigin=eyJpIjoiYjQ4YjZhZjJiMjQ5NGQ2MDk4YjdjYThmZGVjZGI2YTUiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100208- sha1:399748d )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20221012/dc2b969d/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-299386ec-b76c-414e-a362-6a6a64fa5669
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221012/dc2b969d/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-97231665-a3a4-4bc2-9f89-bdd21ee02fa9
Type: image/png
Size: 457 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221012/dc2b969d/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-3653f812-579b-4f6b-84db-aaabbdf0f406
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221012/dc2b969d/attachment-0005.png>