[JIRA] (JSSH-11) Review implementation and tests for BasicParserPool

[Scott Cantor (Jira)]

Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) *commented* on JSSH-11 ( https://shibboleth.atlassian.net/browse/JSSH-11?atlOrigin=eyJpIjoiN2RmMTE4YTgyNzY4NDE0ZTliY2IxY2E5OWE3MDFjMWIiLCJwIjoiaiJ9 )

Re: Review implementation and tests for BasicParserPool ( https://shibboleth.atlassian.net/browse/JSSH-11?atlOrigin=eyJpIjoiN2RmMTE4YTgyNzY4NDE0ZTliY2IxY2E5OWE3MDFjMWIiLCJwIjoiaiJ9 )

I took a look at this, and I would caution that while I think this works for Features, I’m not certain it’s correct for the Attributes, because I think some of them may allow null values. I think Java’s a little overly strict on prohibiting null map values, which limits the ability to use Map.copyOf, and Java doesn’t have Immutable collection builders as far as I know that would allow them to be built up.

Given that we’re not likely to ever get out of Guava, it’s probably not worth messing with it, but arguably we don’t need getters for those collections at all. I tend to only do setters for things that shouldn’t be used externally. So one option is just to dump the getters.

( https://shibboleth.atlassian.net/browse/JSSH-11#add-comment?atlOrigin=eyJpIjoiN2RmMTE4YTgyNzY4NDE0ZTliY2IxY2E5OWE3MDFjMWIiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JSSH-11#add-comment?atlOrigin=eyJpIjoiN2RmMTE4YTgyNzY4NDE0ZTliY2IxY2E5OWE3MDFjMWIiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100208- sha1:399748d )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20221012/b69a97e1/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-eb3133cd-5944-4506-b282-28a639f59053
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221012/b69a97e1/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-90fa3572-7ea3-4567-9885-7a965634acf8
Type: image/png
Size: 457 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221012/b69a97e1/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-386a883b-3447-46f5-ac21-16b5a2004b71
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221012/b69a97e1/attachment-0005.png>