[JIRA] (IDP-1870) Detect duplicate entityIDs when ingesting metadata

[Brent Putman (Jira)]

Brent Putman ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A97de0981-adc3-4044-95ed-131622fad81e ) *commented* on IDP-1870 ( https://shibboleth.atlassian.net/browse/IDP-1870?atlOrigin=eyJpIjoiNzY5MDY5N2Y1MGRmNDI1Nzg0Y2RhZmUyZDhkMzUwNGUiLCJwIjoiaiJ9 )

Re: Detect duplicate entityIDs when ingesting metadata ( https://shibboleth.atlassian.net/browse/IDP-1870?atlOrigin=eyJpIjoiNzY5MDY5N2Y1MGRmNDI1Nzg0Y2RhZmUyZDhkMzUwNGUiLCJwIjoiaiJ9 )

Looking at the code, we already have a WARN level log message to that effect in AbstractMetadataResolver :

log.warn( "{} Detected duplicate EntityDescriptor for entityID: {}" , getLogPrefix(), entityID);

Do you see this in your logs in this case? Note that this only detects duplicates within the same metadata resolver. There’s no way to detect (at least easily or tractably) duplicates across different metadata resolvers.

Is this sufficient, or were you asking for an actual fatal error/exception to be thrown in this case? That would cause the entire metadata ingest to fail at that point, and I doubt that’s really what you would want, but just want to clarify.

( https://shibboleth.atlassian.net/browse/IDP-1870#add-comment?atlOrigin=eyJpIjoiNzY5MDY5N2Y1MGRmNDI1Nzg0Y2RhZmUyZDhkMzUwNGUiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-1870#add-comment?atlOrigin=eyJpIjoiNzY5MDY5N2Y1MGRmNDI1Nzg0Y2RhZmUyZDhkMzUwNGUiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100181- sha1:4b5d772 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20211013/cf4b43bc/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-f5c29cff-5314-4cf3-923a-b8c94878109d
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20211013/cf4b43bc/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-747bc902-4a74-4423-948f-e8f9fab547f5
Type: image/png
Size: 457 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20211013/cf4b43bc/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-6165b9bc-4152-419c-9709-950dc010f0d1
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20211013/cf4b43bc/attachment-0005.png>