[JIRA] (IDP-1870) Detect duplicate entityIDs when ingesting metadata

[Matthew Slowe (Jira)]

Matthew Slowe ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=5c45da4b23f5bf67262143c7 ) *commented* on IDP-1870 ( https://shibboleth.atlassian.net/browse/IDP-1870?atlOrigin=eyJpIjoiZDk5MWFiMDJhNjkwNDFmNmJmNzczNWNiNmFkOTBmZGEiLCJwIjoiaiJ9 )

Re: Detect duplicate entityIDs when ingesting metadata ( https://shibboleth.atlassian.net/browse/IDP-1870?atlOrigin=eyJpIjoiZDk5MWFiMDJhNjkwNDFmNmJmNzczNWNiNmFkOTBmZGEiLCJwIjoiaiJ9 )

I've just done a test (on 4.1.2 as that's what I had to hand) loading two identical files:

$ sha1sum metadata/test/e*
804d32905e5b0b53add00619910b6ca5bffc765d  metadata/test/e1.xml
804d32905e5b0b53add00619910b6ca5bffc765d  metadata/test/e2.xml

With config:

<MetadataProvider id= "ShibbolethMetadata" xsi:type= "ChainingMetadataProvider" ...>

   <MetadataProvider id= "test-duplicate-metadata-1"
           xsi:type= "FilesystemMetadataProvider"
           metadataFile= "/opt/idp4/metadata/test/e1.xml"
           />
   <MetadataProvider id= "test-duplicate-metadata-2"
           xsi:type= "FilesystemMetadataProvider"
           metadataFile= "/opt/idp4/metadata/test/e2.xml"
           />
...
</MetadataProvider>

Nothing of note appears in the idp-warn.log on a full restart (or a shibboleth.MetadataResolverService reload).

In fact, the process log shows it's loaded both successfully:

2021-10-14 08:20:31,365 -  - INFO [org.opensaml.saml.metadata.resolver.impl.AbstractReloadingMetadataResolver:591] - Metadata Resolver FilesystemMetadataResolver test-duplicate-metadata-1: New metadata successfully loaded for '/opt/idp4/metadata/test/e1.xml'
2021-10-14 08:20:31,366 -  - INFO [org.opensaml.saml.metadata.resolver.impl.AbstractReloadingMetadataResolver:396] - Metadata Resolver FilesystemMetadataResolver test-duplicate-metadata-1: Next refresh cycle for metadata provider '/opt/idp4/metadata/test/e1.xml' will occur on '2021-10-14T11:20:31.355871Z' ('2021-10-14T11:20:31.355871Z[GMT]' local time)
2021-10-14 08:20:31,380 -  - INFO [org.opensaml.saml.metadata.resolver.impl.AbstractReloadingMetadataResolver:591] - Metadata Resolver FilesystemMetadataResolver test-duplicate-metadata-2: New metadata successfully loaded for '/opt/idp4/metadata/test/e2.xml'
2021-10-14 08:20:31,380 -  - INFO [org.opensaml.saml.metadata.resolver.impl.AbstractReloadingMetadataResolver:396] - Metadata Resolver FilesystemMetadataResolver test-duplicate-metadata-2: Next refresh cycle for metadata provider '/opt/idp4/metadata/test/e2.xml' will occur on '2021-10-14T11:20:31.379182Z' ('2021-10-14T11:20:31.379182Z[GMT]' local time)

> 
> 
> 
> Note that this only detects duplicates within the same metadata resolver
> 
> 

Would they currently need to be in the same <MetadataProvider ... metadataFile="combined.xml" /> for this warning to trigger at the moment? (I can't actually find it in the git repo)

( https://shibboleth.atlassian.net/browse/IDP-1870#add-comment?atlOrigin=eyJpIjoiZDk5MWFiMDJhNjkwNDFmNmJmNzczNWNiNmFkOTBmZGEiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-1870#add-comment?atlOrigin=eyJpIjoiZDk5MWFiMDJhNjkwNDFmNmJmNzczNWNiNmFkOTBmZGEiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100183- sha1:445115c )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20211014/7252c48a/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-9e536f38-6b1c-42e2-8cda-f513773fca77
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20211014/7252c48a/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-bb3069f2-9a83-43d4-95fc-7c894ab98a68
Type: image/png
Size: 457 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20211014/7252c48a/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-521ecf03-6c80-412d-be58-9eaee791a5ae
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20211014/7252c48a/attachment-0005.png>