[cpp-sp] 02/03: Review comment: Remove artificial constraint on POST size

Rod Widdowson rdw at steadingsoftware.com
Thu May 24 10:25:14 EDT 2018


This is an automated email from the git hooks/post-receive script.

rdw pushed a commit to branch master
in repository cpp-sp.

View the commit online:
http://git.shibboleth.net/view/?p=cpp-sp.git;a=commit;h=12a0266349751f763ea72e314efd48e190be0516

commit 12a0266349751f763ea72e314efd48e190be0516
Author: Rod Widdowson <rdw at steadingsoftware.com>
AuthorDate: Thu May 24 10:53:30 2018 +0100

    Review comment:  Remove artificial constraint on POST size
---
 iis7_shib/IIS7Request.cpp | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/iis7_shib/IIS7Request.cpp b/iis7_shib/IIS7Request.cpp
index f4efb3c..d98fd9b 100644
--- a/iis7_shib/IIS7Request.cpp
+++ b/iis7_shib/IIS7Request.cpp
@@ -336,10 +336,7 @@ const char* IIS7Request::getRequestBody() const
     }
     // TODO Not Thread safe?
     DWORD totalBytesLeft = m_request->GetRemainingEntityBytes();
-    // TODO: this check was specific to the old handler logic, so do we keep this or make it configurable?
-    if (totalBytesLeft > 1024 * 1024) {
-        throw opensaml::SecurityPolicyException("Size of request body exceeded 1M size limit.");
-    }
+
     while (totalBytesLeft) {
         char buf[8192];
         DWORD bytesRead;

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list