[cpp-sp] 01/03: Review comment: Remove dead methods

[Rod Widdowson]

This is an automated email from the git hooks/post-receive script.

rdw pushed a commit to branch master
in repository cpp-sp.

View the commit online:
http://git.shibboleth.net/view/?p=cpp-sp.git;a=commit;h=8d7fdb4b1b3ad8b1b3a552fce40c2dc70eab3cd5

commit 8d7fdb4b1b3ad8b1b3a552fce40c2dc70eab3cd5
Author: Rod Widdowson <rdw at steadingsoftware.com>
AuthorDate: Thu May 24 10:40:07 2018 +0100

    Review comment:  Remove dead methods
---
 iis7_shib/ShibHttpModule.cpp         | 20 --------------------
 iis7_shib/headers/ShibHttpModule.hpp | 14 --------------
 iis7_shib/register.cpp               |  4 +---
 3 files changed, 1 insertion(+), 37 deletions(-)

diff --git a/iis7_shib/ShibHttpModule.cpp b/iis7_shib/ShibHttpModule.cpp
index 3421a6d..281d0eb 100644
--- a/iis7_shib/ShibHttpModule.cpp
+++ b/iis7_shib/ShibHttpModule.cpp
@@ -117,23 +117,3 @@ ShibHttpModule::OnAuthenticateRequest(
     return DoFilter(pHttpContext, pProvider);
 }
 
-// RQ_AUTHENTICATE_REQUEST 
-REQUEST_NOTIFICATION_STATUS
-ShibHttpModule::OnPostAuthenticateRequest(
-    _In_ IHttpContext *             pHttpContext,
-    _In_ IHttpEventProvider *       pProvider
-)
-{
-    return RQ_NOTIFICATION_CONTINUE;
-}
-
-// RQ_PRE_EXECUTE_REQUEST_HANDLER
-REQUEST_NOTIFICATION_STATUS
-ShibHttpModule::OnPreExecuteRequestHandler(
-    _In_ IHttpContext *         pHttpContext,
-    _In_ IHttpEventProvider *   pProvider
-)
-{
-    return RQ_NOTIFICATION_CONTINUE;
-}
-
diff --git a/iis7_shib/headers/ShibHttpModule.hpp b/iis7_shib/headers/ShibHttpModule.hpp
index 5810c9f..9641466 100644
--- a/iis7_shib/headers/ShibHttpModule.hpp
+++ b/iis7_shib/headers/ShibHttpModule.hpp
@@ -36,13 +36,6 @@ public:
             _In_ IHttpEventProvider *   pProvider
         );
 
-    // RQ_PRE_EXECUTE_REQUEST_HANDLER
-    REQUEST_NOTIFICATION_STATUS
-        OnPreExecuteRequestHandler(
-            _In_ IHttpContext *         pHttpContext,
-            _In_ IHttpEventProvider *   pProvider
-        );
-
     // RQ_AUTHENTICATE_REQUEST
     REQUEST_NOTIFICATION_STATUS
         OnAuthenticateRequest(
@@ -50,13 +43,6 @@ public:
             _In_ IAuthenticationProvider *  pProvider
         );
 
-    // RQ_AUTHENTICATE_REQUEST
-    REQUEST_NOTIFICATION_STATUS
-        OnPostAuthenticateRequest(
-            _In_ IHttpContext *             pHttpContext,
-            _In_ IHttpEventProvider *       pProvider
-        );
-
 private:
     REQUEST_NOTIFICATION_STATUS
         DoHandler(
diff --git a/iis7_shib/register.cpp b/iis7_shib/register.cpp
index 7fdca01..6431dab 100644
--- a/iis7_shib/register.cpp
+++ b/iis7_shib/register.cpp
@@ -193,9 +193,7 @@ RegisterModule(
         }
     }
 
-    HRESULT hr = pModuleInfo->SetRequestNotifications(new ShibModuleFactory(), 
-                                                      RQ_BEGIN_REQUEST | RQ_AUTHENTICATE_REQUEST | RQ_PRE_EXECUTE_REQUEST_HANDLER,
-                                                      RQ_AUTHENTICATE_REQUEST);
+    HRESULT hr = pModuleInfo->SetRequestNotifications(new ShibModuleFactory(), RQ_BEGIN_REQUEST | RQ_AUTHENTICATE_REQUEST, 0);
 
     if (SUCCEEDED(hr))
         LogEvent(EVENTLOG_INFORMATION_TYPE, SHIB_NATIVE_INITIALIZED, Priority::INFO, "SHIB_NATIVE_INITIALIZED");

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.