[cpp-sp] 03/03: Review Comments: Do not get anything from the headers

[Rod Widdowson]

This is an automated email from the git hooks/post-receive script.

rdw pushed a commit to branch master
in repository cpp-sp.

View the commit online:
http://git.shibboleth.net/view/?p=cpp-sp.git;a=commit;h=484c7bd3cafce0cf0cfad78a8e7f52d8365e80e3

commit 484c7bd3cafce0cf0cfad78a8e7f52d8365e80e3
Author: Rod Widdowson <rdw at steadingsoftware.com>
AuthorDate: Thu May 24 15:24:00 2018 +0100

    Review Comments: Do not get anything from the headers
    
    In particular remote user is initialized in the constructor
    (to nothing usually), so we don't need to look at it again
    and we never need to get it from the headers.
---
 iis7_shib/IIS7Request.cpp | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/iis7_shib/IIS7Request.cpp b/iis7_shib/IIS7Request.cpp
index d98fd9b..31c57be 100644
--- a/iis7_shib/IIS7Request.cpp
+++ b/iis7_shib/IIS7Request.cpp
@@ -320,12 +320,6 @@ long IIS7Request::getContentLength() const
 
 string IIS7Request::getRemoteUser() const
 {
-    if (m_remoteUser.empty()) {
-        // TODO: seems like this should be server-variable driven only?
-        PCSTR p = m_request->GetHeader("REMOTE_USER");
-        if (p)
-            m_remoteUser = p;
-    }
     return m_remoteUser;
 }
 

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.