sp rpm for Rocky 9

[Paul B. Henson]

I recently spun up an SP under Rocky Linux 9 for the first time, and 
noticed it pulled in the legacy chkconfig and initscripts packages. Red 
Hat 9 and its derivatives are purely systemd out-of-the-box, those 
packages aren't needed for the base OS and exist just to provide 
compatibility with legacy applications.

However, the shibboleth SP is not one of those, it is controlled by 
systemd using the unit file installed at:

	/usr/lib/systemd/system/shibd.service


Looking at the rpm spec file, which appears to be the same across all of 
the various versions of Red Hat, the decision whether to install the 
systemd unit file or the legacy initscript is based on the version, but 
the inclusion of the legacy initscript dependencies is not, and they are 
pulled in across the board whether needed or not.

I see the decision whether or not to use systemd is based on the 
following conditional:

	%if 0%{?suse_version} >= 1210 || 0%{?rhel} >= 7


Ideally, the same condition could be placed around the requirements at 
the top:

	%if "%{_vendor}" == "redhat" || "%{_vendor}" == "amazon"
	[...]
	%if 0%{?rhel} >= 7 || || "%{_vendor}" == "amazon"
	Requires(post): chkconfig
	Requires(preun): chkconfig, initscripts
	#endif
	[...]
	%endif

So these packages would only be pulled in on those operating systems 
that need it, rather than polluting operating systems that don't with 
legacy artifacts. It looks like the Amazon rebuild never uses systemd? 
Dunno, AL 2 is based of RHEL 7...

I know there is no forward development on the SP, but given the timeline 
for a replacement, there will probably be a security patch release or 
something coming up at some point, if possible, it would be nice to fix 
these dependencies in the spec file so if that happens it will be 
cleaned up.

Thanks much…