Failed Windows 3.4.3.0 upgrade

[Dave Bartholomew]

> What you might want to do is stop the service, delete the temp files,
redeploy the war and restart the service.

Did the more-or-less GUI equivalent (decided to keep ".keep") on my dev
server and ended up with the 3.4.1 JARs in edit-webapp\WEB-INF\lib and got
the same error. The single temp file (left on disk after I shut the IdP
down) had both 3.4.1 and 3.4.3 JARs.

Earlier I was asked "Is edit-webapp empty of any jar files (C:\Program
Files (x86)\Shibboleth\IdP\edit-webapp\WEB-INF\lib)?" and I answered "No"
but it wasn't clear to me what the expected/desired state should be. There
were 3.4.1 JARs there (my test server this time).

In case it was supposed to be empty, I moved all files out of it and tried
again and it stayed empty, but the single temp file had both 3.4.1 and
3.4.3 JARs as did the war file (first time I've seen that). The war for a
clean 3.4.3.0 install only had 3.4.3 JARs.

If I update some conf files (that I haven't modified) with the dist files,
is there any reason to remove the R/O attributes?

I should mention that on my dev system, when I tried to upgrade from
3.3.3.1 to 3.4.0.0, I got a message saying that I didn't "have sufficient
privileges to install system services" despite being a domain admin. I
cancelled out and it rolled back and after finding the service marked for
deletion, I restarted the server and was able to install the IdP without
getting that message (with no change in my rights). After some interesting
unresolved Java 10.0.2 issues, I switched to Java 8.x and installed
3.4.1.0 with no permissions issues. I wouldn't expect this to be all that
relevant given that I didn't get any permissions issue on my test server
when I went from 3.4.1.0 to 3.4.3.0, but given that I haven't seen
anything on the list like this, I have the standard "Why me?" question.

Prior to upgrading to 3.4x, everything has gone surprisingly well.

-- Dave