changes to apply after upgrade (include system dir?)

[Cantor, Scott]

> I thought files in /opt/shibboleth-idp/system/ are supposed to get overwritten
> with newer versions when installing a new IDP version over an older one?

Yes.

> I just noticed that 3.3.3 has this in ${idp.home}/system/conf/mvc-beans.xml:
>   <import resource="conditional:${idp.home}/conf/mvc-beans.xml" /> but after
> upgrading my 3.3.2 to 3.3.3 my copy of that file still reads:
>   <import resource="../../conf/mvc-beans.xml" />

The conditional: change should not, AFAIK, be in 3.3.3, that wouldn't work. It is not in the branch in git. If it's in the package, that would be a corruption of the release (and yes, it should have copied that file over top, and would have broken it).

> Why does this matter: When one applies the changes to the config directory
> from 3.3.2 to 3.3.3 the file ${idp.home}/conf/mvc-beans.xml would get
> removed, but unless ${idp.home}/system/conf/mvc-beans.xml
> would get changed accordingly this breaks the update.

No, the update process would not remove the one in conf. It doesn't have the ability or intelligence to remove files like that, it's not RPM.

Something is seriously off. But nobody else has reported a problem, and if that file got changed in the branch it would break.

-- Scott