MFA script subcontext cleanup

[Cantor, Scott]

On 8/11/17, 2:34 PM, "users on behalf of Andrew Morgan" <users-bounces at shibboleth.net on behalf of morgan at orst.edu> wrote:

> However, there are other calls to getSubcontext that are not cleaned up:

The first one includes a second parameter that means "create if not present". The getSubcontext(, true) syntax is a shortcut for creating a new context and adding it, and technically is somewhat sloppy in cases where it might already exist since you'd get existing content in it.

The other calls only return an existing context or null. The MFA flow can't run if they don't exist, so there's not a compelling need to check for null.

> Should input.removeSubcontext(authCtx) be called?  If not, why not?

No. They're created by the system and maintained by it, you'd break it if they were removed, it would fail authentication at some point.

-- Scott