MFA script subcontext cleanup

Andrew Morgan morgan at orst.edu
Fri Aug 11 14:34:12 EDT 2017


In the example MFA transition script, it has:

   if (mfaCtx.isAcceptable()) {
     resCtx = input.getSubcontext("net.shibboleth.idp.attribute.resolver.context.AttributeResolutionContext", true);
     ...
     input.removeSubcontext(resCtx);   // cleanup


However, there are other calls to getSubcontext that are not cleaned up:

   // Go straight to second factor if we have to, or set up for an attribute lookup first.
   authCtx = input.getSubcontext("net.shibboleth.idp.authn.context.AuthenticationContext");
   mfaCtx = authCtx.getSubcontext("net.shibboleth.idp.authn.context.MultiFactorAuthenticationContext");


Should input.removeSubcontext(authCtx) be called?  If not, why not?

Thanks,
 	Andy


More information about the users mailing list