New warning message after upgrade from 3.2.1.1 to 3.3 on Windows (MSI Installer)

[Cantor, Scott]

> So that WARN message is generated at time of loading/reloading saml-
> nameid.xml.

I do see it, yes. However...

> But no warning/problems appear to happen while running, it
> honors that config just fine and sends the right response. So this is not
> impacting operation of the IdP.

When I saw the message, I changed the constructor-arg in the condition bean to explicitly name the constructor argument ("candidates") and that stopped the warning. So I debugged it and verified that while it's probably in fact calling the right constructor, the warning obviously means it's trying to convert first and then picking the "better" constructor.

There are a host of problems with that section of the code because of all the things I did without realizing how they would interact. While it mostly seems to work now, and at least warns also, you don't want that. Just specify name="candidates" if you want to pass a list of strings to the relying party ID predicate.

Even better, don't do it. There are usually better choices than those kinds of activation conditions. Pretty much always.

-- Scott