attribute resolver LDAP pool name

[Youssef GHORBAL]

Hello,

	While troubleshooting an issue with the IdP and LDAP pooling, I noticed in the logs that the auth LDAP pools are named. For example in the logs we can see :

	DEBUG [org.ldaptive.pool.BlockingConnectionPool:?] - end validate task for [org.ldaptive.pool.BlockingConnectionPool at 1371999636::name=bind-pool ...
	DEBUG [org.ldaptive.pool.BlockingConnectionPool:?] - end validate task for [org.ldaptive.pool.BlockingConnectionPool at 843157400::name=search-pool ...

	the "bind-pool” and "search-pool” are refereced in conf/authn/ldap-authn-config.xml (bean bindPooledConnectionFactory & anonSearchConnectionPool)

	In the logs I also see “null” named pool :
	
	DEBUG [org.ldaptive.pool.BlockingConnectionPool:?] - end prune task for [org.ldaptive.pool.BlockingConnectionPool at 981012032::name=null

	It happens that I have the attribute resolving connector pooled, so I guess that line reference the attribute resolving pool, but I’m not sure.

	Is there any way to name the attribute resolver connection pool (the same way as bind-pool and search-pool) that would help clarify things.

	I naively tried adding something like :

	<dc:ConnectionPool
	    name=“resolve-pool"
            minPoolSize="%{idp.pool.LDAP.minSize:3}"
            maxPoolSize="%{idp.pool.LDAP.maxSize:10}"
            blockWaitTime="PT3S"
            validatePeriodically="%{idp.pool.LDAP.validatePeriodically:true}"
            validateTimerPeriod="PT4M"
            failFastInitialize="%{idp.pool.LDAP.failFastInitialize:false}" />

	But that gererated an error while reloading :

net.shibboleth.utilities.java.support.service.ServiceException: org.springframework.beans.factory.xml.XmlBeanDefinitionStoreException: Line 181 in XML document from file [/opt/shibboleth-idp/conf/attribute-resolver.xml] is invalid; nested exception is org.xml.sax.SAXParseException; lineNumber: 181; columnNumber: 78; cvc-complex-type.3.2.2: Attribute 'name' is not allowed to appear in element 'dc:ConnectionPool’.

Youssef Ghorbal
Institut Pasteur