SocketFactory property duplication

[Cantor, Scott]

On 5/24/17, 2:33 PM, "dev on behalf of Brent Putman" <dev-bounces at shibboleth.net on behalf of putmanb at georgetown.edu> wrote:

> Yes, exactly.  We shipped some earlier versions with the first one, and later we changed it to the second one (the preferred
> socket factory class changed names).  So the first can completely go away as soon as we can get rid of deprecated properties.

Ok, that's what I needed to confirm at this point.

> I suppose it doesn't need to be in the commented out examples in services.properties at this point.  The only use of those is in
> global-system.xml for wiring the property on HttpClient factory beans:

Exactly, things are very confusing when we're not just removing the "optional" deprecated stuff when we deprecate it. But for now it's fine, we just need to track this and my plan was to hopefully add a way for us to detect any deprecated properties set and warn about them.

> I imagine we have to keep that Spring syntax there until 4.0.0, right?  Unless our policy on property deprecation is different than
> in other places.

Yes, it would be removed then, because 3.4.0 will warn if the other one is being set.

-- Scott