SocketFactory property duplication

[Brent Putman]

On 5/24/17 2:17 PM, Cantor, Scott wrote:
> I know I've asked before, but why do we have both of these?
>
> #idp.httpclient.useTrustEngineTLSSocketFactory = false
> #idp.httpclient.useSecurityEnhancedTLSSocketFactory = false
>
> Near as I can tell, the former should be deprecated in favor of the latter?

Yes, exactly.  We shipped some earlier versions with the first one, and
later we changed it to the second one (the preferred socket factory
class changed names).  So the first can completely go away as soon as
we can get rid of deprecated properties.

I suppose it doesn't need to be in the commented out examples in
services.properties at this point.  The only use of those is in
global-system.xml for wiring the property on HttpClient factory beans:

p:tLSSocketFactory="#{
%{idp.httpclient.useTrustEngineTLSSocketFactory:false} or
%{idp.httpclient.useSecurityEnhancedTLSSocketFactory:false} ?
@'shibboleth.SecurityEnhancedTLSSocketFactory' : null }" 


I imagine we have to keep that Spring syntax there until 4.0.0, right? 
Unless our policy on property deprecation is different than in other
places.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/dev/attachments/20170524/e2200a59/attachment.html>