Actions not identified/identifiable?

[Cantor, Scott]

On 9/25/16, 1:32 PM, "dev on behalf of Tom Zeller" <dev-bounces at shibboleth.net on behalf of tzeller at dragonacea.biz> wrote:

>    > I was surprised to find that we never inherited the AbstractProfileAction hierarchy to give them IDs.
>    
>    https://marc.info/?l=shibboleth-dev&m=139542782403560&w=2

Figures. I read the thread, and it's making me question why I ever felt like we needed that log prefix in the action classes to start with, probably somebody should have pushed back there.

But the sense of the thread was:

- we shouldn't force IDness on the actions if it's not needed
- it was making the tests hard

I'm not sure what the latter issue was, but I guess in my mind, well, there's now a reasonable use case for the IDs (even if it's somewhat obscure, I don't know how important this timer stuff really is).

With all the bean post processors and machinery we built, I'm not sure what breaks if the actions were to inherit from AbstractIdentifiableInitializable at this point. I wonder if some of this complexity was overtaken by events and solved.

-- Scott