Default LDAP connection pool properties ?

[Daniel Fisher]

On Tue, Sep 6, 2016 at 7:35 PM, Tom Zeller <tzeller at dragonacea.biz> wrote:

> Should connection pool properties in attribute-resolver-ldap.xml have
> default values ? e.g. blockWaitTime="%{idp.pool.LDAP.blockWaitTime:PT5S}”
>

Yes, I think so. In fact the authn configuration defines a default in the
config.


>
> Should connection pool properties in ldap.properties be uncommented ?
>

There probably isn't any harm in doing so.
Really just want deployers to consider them, regardless of whether or not
they accept the defaults.


>
> Should the time-based properties be durations ? I don’t remember where we
> left off with Durations and ldaptive.
>

Not yet. I hope to merge a fix for that soon.


>
> I’ve tried a variety of combinations, but the IdP fails to start with :
> org.springframework.beans.factory.UnsatisfiedDependencyException: Error
> creating bean with name '(inner bean)...': Unsatisfied dependency expressed
> through method 'buildDuration' parameter 0: Could not convert argument
> value of type [java.lang.String] to required type [long]: Failed to convert
> value of type [java.lang.String] to required type [long]; nested exception
> is java.lang.NumberFormatException: For input string: “undefined"
>

I believe we used 'undefined' to avoid property not found exceptions in
cases where property resolution was occurring on beans that were not being
used and therefore did not need defined properties.
I would start with connectTimeout or responseTimeout.

--Daniel Fisher
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/dev/attachments/20160907/ea98a274/attachment.html>