Default LDAP connection pool properties ?

[Tom Zeller]

Probably Daniel and/or Rod :

Some questions about the new[1] default connection pool[2] in attribute-resolver-ldap.xml :

Should connection pool properties in attribute-resolver-ldap.xml have default values ? e.g. blockWaitTime="%{idp.pool.LDAP.blockWaitTime:PT5S}”

Should connection pool properties in ldap.properties be uncommented ?

Should the time-based properties be durations ? I don’t remember where we left off with Durations and ldaptive.

I’ve tried a variety of combinations, but the IdP fails to start with :
org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name '(inner bean)...': Unsatisfied dependency expressed through method 'buildDuration' parameter 0: Could not convert argument value of type [java.lang.String] to required type [long]: Failed to convert value of type [java.lang.String] to required type [long]; nested exception is java.lang.NumberFormatException: For input string: “undefined"

There are several places where ‘buildDuration’ appears in the LDAP DC parser, but it was not obvious to me which property was un-convertable.

Haven’t dug any farther, ran out of time...

Thx!
Tom

[1] http://svn.shibboleth.net/view/java-identity-provider/trunk/idp-conf/src/main/resources/conf/attribute-resolver-ldap.xml?r1=8275&r2=8274&pathrev=8275
[2] https://issues.shibboleth.net/jira/browse/IDP-965
[3] https://wiki.shibboleth.net/confluence/display/IDP30/ConnectionPool