R4481 Checkstyle Parameter Rename Issue

[Cantor, Scott]

On 9/7/16 7:11 AM, Marvin Addison wrote:
> It looks like the checkstyle cleanup in r4481 caused some method
> parameter names to change in MemcachedStorageService. I see that I
> violated the "don't name parameters same as arguments" rule.

Yeah, sorry, I was cleaning up some other code and that particular idiom
is just one of my pet peeves (I hate this.anything) so I did it without
thinking.

I think the real problem is that we need to stop using constructor
arguments so much.

> Probably the safest thing to do is change the private field names and
> revert the parameter names. Thoughts?

I'll revert it later today.

I don't have a good rule of thumb here, we know it's a problem. I think
the only real takeaways are:

- c'tor arguments are bad
- Scott needs to be more careful

-- Scott