R4481 Checkstyle Parameter Rename Issue

[Marvin Addison]

It looks like the checkstyle cleanup in r4481 caused some method parameter
names to change in MemcachedStorageService. I see that I violated the
"don't name parameters same as arguments" rule. In any case this breaks
Spring wiring that uses parameter name references in constructor arguments:

    <bean id="shibboleth.MemcachedStorageService"

class="org.opensaml.storage.impl.memcached.MemcachedStorageService"
          c:timeout="5">
        <constructor-arg name="client">
            ...
        </constructor-arg>
    </bean>

It's easy to fix but unfortunately that's the style that I used in the
documentation because I find it more readable. (The cost of the additional
readability is painfully clear.) That means that this change will probably
break any deployers using memcached on the 3.3.0 upgrade. Probably the
safest thing to do is change the private field names and revert the
parameter names. Thoughts?

Bigger picture we may want to take a stand on using this style of Spring
wiring.

M
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/dev/attachments/20160907/af2b77a6/attachment.html>