MessageHandlers and SOAP faults

[Brent Putman]

On 6/20/15 1:51 PM, Cantor, Scott wrote:
> On 6/19/15, 8:11 PM, "dev on behalf of Brent Putman" <dev-bounces at shibboleth.net on behalf of putmanb at georgetown.edu> wrote:
>
>> And on the AddSOAPFault ProfileAction:  In addition to my earlier suggestion that it check for the presence of an outbound Fault already registered per the above, it should probably "emit" any Fault it builds (by Event mapping, etc) using the same mechanism, rather than (unnaturally) sticking it into the MessageContext getMessage().
>>
>> I think this is a much cleaner and consistent solution.  Do you have any objections to that?  I think it should be a completely internal change.
> No objection, just needs to be fully tested.

FYI, I just made this change.  I've tested it by forcing an NPE which
which causes the class cast exception we were seeing because of the
AddECPResponseHeaderHandler, and this fixes it.  Haven't seen any other
issues except a debug logging issue in EncodeAction, also fixed.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/dev/attachments/20151028/b2ab1624/attachment.html>