Hardcoded references to error.jsp in AuthnEngine

[Christopher Bongaarts]

Was tracking down where users were reporting the 2.4.x equivalent of the 
griffon page ("Our Identity Provider") when accessing /idp/AuthnEngine 
despite our having configured alternate error page locations in 
web.xml.  Discovered that there are several hard-coded references to 
forwardRequest("/error.jsp", httpRequest, httpResponse) in 
AuthenticationEngine.java.  Since this path seems to keep the HTTP error 
code at 200, the web.xml error pages are never triggered (they only 
activate on 500 or 404 errors).

A couple questions:
- Should I bother filing a bug on this in Jira, since 2.x will be EOL 
soon and the 3.x code is radically different?
- Is there a preferred way to address this?  Explicitly setting a 500 
response code?  Using a catch-all (or at least catch 200, or does that 
even make sense) error-page in web.xml?  Changing the forwardRequest to 
a sendError?

-- 
%%  Christopher A. Bongaarts   %%  cab at umn.edu          %%
%%  OIT - Identity Management  %%  http://umn.edu/~cab  %%
%%  University of Minnesota    %%  +1 (612) 625-1809    %%