A couple of TODOs in the attributes code.

[Daniel Fisher]

On Tue, Oct 21, 2014 at 6:40 AM, Rod Widdowson <rdw at steadingsoftware.com>
wrote:

> I have been doing some housework and cleaning some TODOs.
>
> The next is asks whether we 'use queryUsesStoredProcedure', and again I
> think that the answer is 'no'?
>

AFAICT, that parameter is only used to throw an exception on validation if
the database doesn't support stored procedures.
If that's all we want out of that parameter, it's easy functionality to
port.


> The last TODO is about moving hard wired defaults from the LDAP parsers
> into
> the bean definitions.   This is not just a simple matter of adding some
> constants into beans because firstly there are non-custom-spring ways of
> setting up the beans, and secondly in many cases the beans are not ours -
> they belong to ldaptive.
>
> I'm thinking that the best solution is to have subclasses of the ldaptive
> beans with the defaults in place.  But, I'm not 100% convinced:
>   - It could be said that we are moving the defaults from one hard to find
> location to another.
>   - And if people really want the fine control, then they will not be using
> our custom schema, they'll use Spring.
>

Subclassing seems like a lot of effort. +1 for Scott's comment to just
javadoc it.

--Daniel Fisher
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://shibboleth.net/pipermail/dev/attachments/20141021/dbb484cf/attachment.html