Impl package naming

Cantor, Scott cantor.2 at osu.edu
Mon Mar 31 11:08:19 EDT 2014


Something I've neglected to note, we have a lot of inconsistency in
packaging naming between the IdP and OpenSAML modules when it comes to
implementation classes. We put the "impl" part of the package name in
different spots, which is kind of annoying.

e.g.

org.opensaml.saml.saml1.core.impl

org.opensaml.saml.saml1.profile.impl

vs.

net.shibboleth.idp.saml.impl.profile.saml1

It's obviously a disruptive change to fix, but I'm getting kind of tired
of going back and forth. If I'm willing to do the work and clean up the
bean files, should I do that, maybe this weekend?

I have a preference for the OpenSAML naming, as it takes a package of APIs
and adds impl to the end, which is kind of what you'd expect IMHO.

-- Scott




More information about the dev mailing list