[java-shib-shared] branch main updated: JSSH-71 Remove the impact of the DestructableComponent Interface

[Codeberg]

This is an automated email from the git hooks/post-receive script.

codeberg pushed a commit to branch main
in repository java-shib-shared.

View the commit online:
https://codeberg.org/Shibboleth/java-shib-shared/commit/50491b372bc78e9967ec9011ab0790a09451da0e

The following commit(s) were added to refs/heads/main by this push:
     new 50491b37 JSSH-71 Remove the impact of the DestructableComponent Interface
50491b37 is described below

commit 50491b372bc78e9967ec9011ab0790a09451da0e
Author: Rod Widdowson <rdw at steadingsoftware.com>
AuthorDate: Wed Jul 29 18:30:51 2026 +0100

    JSSH-71 Remove the impact of the DestructableComponent Interface
    
    https://shibboleth.atlassian.net/browse/JSSH-71
    
    FileCachingHttpClientFactoryBean does not have call destroy().
    The only thing it can cache has the annotation so it can call that
---
 .../spring/httpclient/factory/FileCachingHttpClientFactoryBean.java    | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/shib-networking-spring/src/main/java/net/shibboleth/shared/spring/httpclient/factory/FileCachingHttpClientFactoryBean.java b/shib-networking-spring/src/main/java/net/shibboleth/shared/spring/httpclient/factory/FileCachingHttpClientFactoryBean.java
index c8a1f1d0..bd8a68e4 100644
--- a/shib-networking-spring/src/main/java/net/shibboleth/shared/spring/httpclient/factory/FileCachingHttpClientFactoryBean.java
+++ b/shib-networking-spring/src/main/java/net/shibboleth/shared/spring/httpclient/factory/FileCachingHttpClientFactoryBean.java
@@ -53,9 +53,6 @@ public class FileCachingHttpClientFactoryBean extends FileCachingHttpClientBuild
     /** {@inheritDoc} */
     @OnTeardown
     public void destroy() {
-        if (singletonInstance instanceof DestructableComponent c) {
-            c.destroy();
-        }
         AnnotationsSupport.callOnTeardownAnnotations(singletonInstance);
     }
 

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.