[java-shib-shared] branch main updated: JSSH-71 Remove the impact of the DestructableComponent Interface

[Codeberg]

This is an automated email from the git hooks/post-receive script.

codeberg pushed a commit to branch main
in repository java-shib-shared.

View the commit online:
https://codeberg.org/Shibboleth/java-shib-shared/commit/7bbcc4b988f21dc727d019a58c3e5e03364bd93d

The following commit(s) were added to refs/heads/main by this push:
     new 7bbcc4b9 JSSH-71 Remove the impact of the DestructableComponent Interface
7bbcc4b9 is described below

commit 7bbcc4b988f21dc727d019a58c3e5e03364bd93d
Author: Rod Widdowson <rdw at steadingsoftware.com>
AuthorDate: Wed Jul 29 15:22:59 2026 +0100

    JSSH-71 Remove the impact of the DestructableComponent Interface
    
    https://shibboleth.atlassian.net/browse/JSSH-71
    
    Fix logging.  Code was wrong, annotations were wrong.  No, I didnt 'vibe code' it.
---
 .../net/shibboleth/shared/primitive/AnnotationsSupport.java    | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/shib-support/src/main/java/net/shibboleth/shared/primitive/AnnotationsSupport.java b/shib-support/src/main/java/net/shibboleth/shared/primitive/AnnotationsSupport.java
index 605629f4..8fbc46c3 100644
--- a/shib-support/src/main/java/net/shibboleth/shared/primitive/AnnotationsSupport.java
+++ b/shib-support/src/main/java/net/shibboleth/shared/primitive/AnnotationsSupport.java
@@ -69,14 +69,14 @@ public final class AnnotationsSupport {
      * @param suppliedName the name, if we know it already
      * @return the best name we could
      */
-    static @Nonnull String getNameFor(@Nonnull final Object obj, @Nullable String suppliedName) {
+    static @Nonnull private String getNameFor(@Nonnull final Object obj, @Nullable final String suppliedName) {
         String result = suppliedName;
-        if (suppliedName == null) {
+        if (result == null) {
             if (obj instanceof IdentifiedComponent) {
-                suppliedName = ((IdentifiedComponent)obj).getId();
+                result = ((IdentifiedComponent)obj).getId();
             }
-            if (suppliedName == null) {
-                suppliedName = "Unidentified bean of type " + obj.getClass().getName();
+            if (result == null) {
+                result = "Unidentified bean of type " + obj.getClass().getName();
             }
         }
         return result;

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.