[cpp-sp] 01/02: CPPSP-28 Windows Installers for Sp4 Agents

[Codeberg]

This is an automated email from the git hooks/post-receive script.

codeberg pushed a commit to branch main
in repository cpp-sp.

View the commit online:
https://codeberg.org/Shibboleth/cpp-sp/commit/3f2010f5dc9e223b25265aba60c105b23cc280e0

commit 3f2010f5dc9e223b25265aba60c105b23cc280e0
Author: Rod Widdowson <rdw at steadingsoftware.com>
AuthorDate: Tue Jan 20 16:20:22 2026 +0000

    CPPSP-28 Windows Installers for Sp4 Agents
    
    https://shibboleth.atlassian.net/browse/CPPSP-28 CPPSP-28 Windows Installers for Sp4 Agents
    
    Add a clarifying comment about unload.
    
    Lock down C:\opt\shibboleth-sp\var\cache\shibboleth-sp\sessions explicitly
    since it may get created before its parents and hence not inherit the correct
    permissions.   Who knows why
---
 msi/wix6/sp4.wxs | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/msi/wix6/sp4.wxs b/msi/wix6/sp4.wxs
index 8ba1e94e..fbd4da59 100644
--- a/msi/wix6/sp4.wxs
+++ b/msi/wix6/sp4.wxs
@@ -106,7 +106,12 @@
                     <Permission User="[WEBSERVER_USER]" GenericAll="yes" />
                 </CreateFolder>
 
-                <CreateFolder Directory="varCacheShibSessions"/>
+                <CreateFolder Directory="varCacheShibSessions">
+                    <Permission User="[WIX_ACCOUNT_ADMINISTRATORS]" GenericAll="yes" />
+                    <Permission User="[WIX_ACCOUNT_LOCALSYSTEM]" GenericAll="yes" />
+                    <Permission User="[WIX_ACCOUNT_USERS]" GenericAll="no" />
+                    <Permission User="[WEBSERVER_USER]" GenericAll="yes" />
+                </CreateFolder>
 
             </Component>
 
@@ -190,6 +195,7 @@
        <CustomAction Id="SetIISInstall" Property="QtIISInstall"
                      Value=""[WindowsFolder]\System32\InetSrv\appcmd.exe" install module /name:ShibNative /image:"[#IIS_lib]" /precondition:"bitness64""/>
 
+       <!-- Note that further testing shows that the delete before uninstall may not always be needed, but doing it is benign -->
        <CustomAction Id="QtIISDelete" DllEntry="WixQuietExec" Execute="deferred" Impersonate="no" BinaryRef="Wix4UtilCA_$(sys.BUILDARCHSHORT)" Return="ignore"/>
        <CustomAction Id="SetIISDelete" Property="QtIISDelete"
                      Value=""[WindowsFolder]\System32\InetSrv\appcmd.exe" delete module ShibNative" />

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.