[cpp-sp] 02/02: Look at every request

[Codeberg]

This is an automated email from the git hooks/post-receive script.

codeberg pushed a commit to branch main
in repository cpp-sp.

View the commit online:
https://codeberg.org/Shibboleth/cpp-sp/commit/db0b8f4545df649dd566232209fd390deab93425

commit db0b8f4545df649dd566232209fd390deab93425
Author: Rod Widdowson <rdw at steadingsoftware.com>
AuthorDate: Tue Jan 6 14:39:20 2026 +0000

    Look at every request
    
    We need to look at everything, so remove the optimization to only look at
    /Shibboleth.sso/…
---
 iis/ShibHttpModule.cpp | 13 ++++---------
 1 file changed, 4 insertions(+), 9 deletions(-)

diff --git a/iis/ShibHttpModule.cpp b/iis/ShibHttpModule.cpp
index 7fce99d9..fb8a9920 100644
--- a/iis/ShibHttpModule.cpp
+++ b/iis/ShibHttpModule.cpp
@@ -66,15 +66,10 @@ ShibHttpModule::DoHandler(
     wstring handlerPrefix(output);
     delete[] output;
 
-
-    // Quickly check the URL.
-    // Calling GetScriptName is safe here since we don't care about "visible to other filters" paths, just our path.
-    // This saves us converting from 8 bit ascii up to 16 bit for the compare against something which was only in 16
-    // bits to speed this path.  In V4 we can look at the local request
-    const wstring url(pHttpContext->GetScriptName());
-    if (url.length() < handlerPrefix.length() || !boost::starts_with(url, handlerPrefix))
-        return RQ_NOTIFICATION_CONTINUE;
-
+    //
+    // We used to only call the constructor if we knew the request is for us,
+    // but we cannot tell anymore.
+    //
     IIS7Request handler(pHttpContext, pProvider, false, *site);
 
     pair<bool, long> res = handler.getAgent().doHandler(handler);

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.