[java-shib-shared] branch main updated: JSSH-54: HttpClientBuilder RequestConfig default for responseTimeout

[Brent Putman]

This is an automated email from the git hooks/post-receive script.

putmanb pushed a commit to branch main
in repository java-shib-shared.

View the commit online:
http://git.shibboleth.net/view/?p=java-shib-shared.git;a=commit;h=9df5a3bff84efb18079bc91e140d488b9dc4a042

The following commit(s) were added to refs/heads/main by this push:
     new 9df5a3bf JSSH-54: HttpClientBuilder RequestConfig default for responseTimeout
9df5a3bf is described below

commit 9df5a3bff84efb18079bc91e140d488b9dc4a042
Author: Brent Putman <putmanb at georgetown.edu>
AuthorDate: Fri Oct 18 13:06:51 2024 -0400

    JSSH-54: HttpClientBuilder RequestConfig default for responseTimeout
    
    Update default to zero seconds, so as not to change behavior in a minor
    release.
---
 .../net/shibboleth/shared/httpclient/HttpClientBuilder.java   | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/shib-networking/src/main/java/net/shibboleth/shared/httpclient/HttpClientBuilder.java b/shib-networking/src/main/java/net/shibboleth/shared/httpclient/HttpClientBuilder.java
index c131d30d..2b5050c7 100644
--- a/shib-networking/src/main/java/net/shibboleth/shared/httpclient/HttpClientBuilder.java
+++ b/shib-networking/src/main/java/net/shibboleth/shared/httpclient/HttpClientBuilder.java
@@ -109,7 +109,8 @@ public class HttpClientBuilder {
      */
     @Nonnull private Duration connectionRequestTimeout;
     
-    /** Determines the timeout until arrival of a response from the opposite endpoint. */
+    /** Determines the timeout until arrival of a response from the opposite endpoint.
+     * Default value: (0 seconds) */
     @Nonnull private Duration responseTimeout;
     
     /**
@@ -230,7 +231,7 @@ public class HttpClientBuilder {
         socketLocalAddress = null;
         socketBufferSize = 8192;
         socketTimeout = Duration.ofSeconds(60);
-        responseTimeout = Duration.ofSeconds(60);
+        responseTimeout = Duration.ofSeconds(0);
         connectionTimeout = Duration.ofSeconds(60);
         connectionRequestTimeout = Duration.ofSeconds(60);
         connectionDisregardTLSCertificate = false;
@@ -275,7 +276,7 @@ public class HttpClientBuilder {
         socketLocalAddress = null;
         socketBufferSize = 8192;
         socketTimeout = Duration.ofSeconds(60);
-        responseTimeout = Duration.ofSeconds(60);
+        responseTimeout = Duration.ofSeconds(0);
         connectionTimeout = Duration.ofSeconds(60);
         connectionRequestTimeout = Duration.ofSeconds(60);
         connectionDisregardTLSCertificate = false;
@@ -376,7 +377,7 @@ public class HttpClientBuilder {
     }
 
     /**
-     * Gets the timeout until arrival of a response from the opposite endpoint.
+     * Gets the timeout until arrival of a response from the opposite endpoint. A value of zero indicates no timeout.
      * 
      * @return the response timeout
      */
@@ -385,7 +386,7 @@ public class HttpClientBuilder {
     }
 
     /**
-     * Gets the timeout until arrival of a response from the opposite endpoint.
+     * Gets the timeout until arrival of a response from the opposite endpoint. A value of zero indicates no timeout.
      * 
      * @param timeout the response timeout
      */

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.