[java-shib-shared] branch main updated: JSSH-54: HttpClientBuilder RequestConfig default for responseTimeout

[Brent Putman]

This is an automated email from the git hooks/post-receive script.

putmanb pushed a commit to branch main
in repository java-shib-shared.

View the commit online:
http://git.shibboleth.net/view/?p=java-shib-shared.git;a=commit;h=7eddeba5eda38cb82386249ac698770efb23954b

The following commit(s) were added to refs/heads/main by this push:
     new 7eddeba5 JSSH-54: HttpClientBuilder RequestConfig default for responseTimeout
7eddeba5 is described below

commit 7eddeba5eda38cb82386249ac698770efb23954b
Author: Brent Putman <putmanb at georgetown.edu>
AuthorDate: Fri Oct 18 12:53:17 2024 -0400

    JSSH-54: HttpClientBuilder RequestConfig default for responseTimeout
    
    ... is non-sensical. Units matter, apparently.
---
 .../main/java/net/shibboleth/shared/httpclient/HttpClientBuilder.java | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/shib-networking/src/main/java/net/shibboleth/shared/httpclient/HttpClientBuilder.java b/shib-networking/src/main/java/net/shibboleth/shared/httpclient/HttpClientBuilder.java
index 88eca34c..c131d30d 100644
--- a/shib-networking/src/main/java/net/shibboleth/shared/httpclient/HttpClientBuilder.java
+++ b/shib-networking/src/main/java/net/shibboleth/shared/httpclient/HttpClientBuilder.java
@@ -230,7 +230,7 @@ public class HttpClientBuilder {
         socketLocalAddress = null;
         socketBufferSize = 8192;
         socketTimeout = Duration.ofSeconds(60);
-        responseTimeout = Duration.ofNanos(60);
+        responseTimeout = Duration.ofSeconds(60);
         connectionTimeout = Duration.ofSeconds(60);
         connectionRequestTimeout = Duration.ofSeconds(60);
         connectionDisregardTLSCertificate = false;
@@ -275,7 +275,7 @@ public class HttpClientBuilder {
         socketLocalAddress = null;
         socketBufferSize = 8192;
         socketTimeout = Duration.ofSeconds(60);
-        responseTimeout = Duration.ofNanos(60);
+        responseTimeout = Duration.ofSeconds(60);
         connectionTimeout = Duration.ofSeconds(60);
         connectionRequestTimeout = Duration.ofSeconds(60);
         connectionDisregardTLSCertificate = false;

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.