[java-idp-plugin-webauthn] branch main updated: Move Icon column to the other side of the Authenticator column

Phil Smart philip.smart at jisc.ac.uk
Fri Oct 11 16:35:26 UTC 2024


This is an automated email from the git hooks/post-receive script.

philsmart pushed a commit to branch main
in repository java-idp-plugin-webauthn.

View the commit online:
http://git.shibboleth.net/view/?p=java-idp-plugin-webauthn.git;a=commit;h=fff5f5dbe49ebab98bc1c7f08d5959d1882749ee

The following commit(s) were added to refs/heads/main by this push:
     new fff5f5d  Move Icon column to the other side of the Authenticator column
fff5f5d is described below

commit fff5f5dbe49ebab98bc1c7f08d5959d1882749ee
Author: Phil Smart <philip.smart at jisc.ac.uk>
AuthorDate: Fri Oct 11 17:35:23 2024 +0100

    Move Icon column to the other side of the Authenticator column
    
     - It seems more logical the icon then relates to the authenticator
---
 .../idp/plugin/authn/webauthn/views/webauthn-register.vm | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/webauthn-impl/src/main/resources/net/shibboleth/idp/plugin/authn/webauthn/views/webauthn-register.vm b/webauthn-impl/src/main/resources/net/shibboleth/idp/plugin/authn/webauthn/views/webauthn-register.vm
index d62af3b..0d14c78 100644
--- a/webauthn-impl/src/main/resources/net/shibboleth/idp/plugin/authn/webauthn/views/webauthn-register.vm
+++ b/webauthn-impl/src/main/resources/net/shibboleth/idp/plugin/authn/webauthn/views/webauthn-register.vm
@@ -126,26 +126,26 @@ $response.addHeader("Content-Security-Policy", "default-src 'none'; style-src 's
                      #if ($webauthnRegContext.existingCredentials)
                          <table>
                             <tr>
-                               <th>#springMessageText("idp.webauthn.register.table.header.keyName", "Key Name")</th>
-                               <th>#springMessageText("idp.webauthn.register.table.header.authenticatorIcon", "Icon")</th> 
+                               <th>#springMessageText("idp.webauthn.register.table.header.keyName", "Key Name")</th>                               
                                <th>#springMessageText("idp.webauthn.register.table.header.authenticatorDescription", "Authenticator")</th>
+                               <th>#springMessageText("idp.webauthn.register.table.header.authenticatorIcon", "Icon")</th> 
                                <th>#springMessageText("idp.webauthn.register.table.header.passkey", "Passkey?")</th>
                                <th>#springMessageText("idp.webauthn.register.table.header.registrationTime", "Registration Time")</th>
                                <th>#springMessageText("idp.webauthn.register.table.header.action", "Action")</th>
                             </tr>
                             #foreach($cred in $webauthnRegContext.existingCredentials)
                             <tr>
-                               <td>$encoder.encodeForHTML($cred.credentialRegistration.nickname)</td>
-                               #if ($cred.icon)
-                                    <td> <img class="authenticator-logo" src="$encoder.encodeForHTML($cred.icon)" alt="authenticator-icon"/></td> 
-                               #else
-                                    <td></td>
-                               #end
+                               <td>$encoder.encodeForHTML($cred.credentialRegistration.nickname)</td>                              
                                #if ($cred.authenticatorDescription)
                                    <td>$encoder.encodeForHTML($cred.authenticatorDescription)</td>
                                #else
                                     <td>#springMessageText("idp.webauthn.register.table.unknownCredential", "unknown")</td>
                                #end
+                               #if ($cred.icon)
+                                    <td> <img class="authenticator-logo" src="$encoder.encodeForHTML($cred.icon)" alt="authenticator-icon"/></td> 
+                               #else
+                                    <td></td>
+                               #end
                                <td>$encoder.encodeForHTML($webAuthnEncoder.formatDiscoverable($cred.credentialRegistration.isDiscoverable()))</td>
                                <td>$encoder.encodeForHTML($webAuthnEncoder.formatInstant($cred.credentialRegistration.registrationTime))</td>
                                <td>

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list