[java-idp-plugin-webauthn] branch main updated: Improve registration view

[Phil Smart]

This is an automated email from the git hooks/post-receive script.

philsmart pushed a commit to branch main
in repository java-idp-plugin-webauthn.

View the commit online:
http://git.shibboleth.net/view/?p=java-idp-plugin-webauthn.git;a=commit;h=38ff1cab4e86483073501e70b16bcef5905c1306

The following commit(s) were added to refs/heads/main by this push:
     new 38ff1ca  Improve registration view
38ff1ca is described below

commit 38ff1cab4e86483073501e70b16bcef5905c1306
Author: Phil Smart <philip.smart at jisc.ac.uk>
AuthorDate: Fri Oct 11 16:44:42 2024 +0100

    Improve registration view
    
     - add icons to their own column
---
 .../shibboleth/idp/plugin/authn/webauthn/css/webauthn.css  |  2 +-
 .../idp/plugin/authn/webauthn/views/webauthn-register.vm   | 14 +++++++-------
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/webauthn-impl/src/main/resources/net/shibboleth/idp/plugin/authn/webauthn/css/webauthn.css b/webauthn-impl/src/main/resources/net/shibboleth/idp/plugin/authn/webauthn/css/webauthn.css
index 6e40392..719675a 100644
--- a/webauthn-impl/src/main/resources/net/shibboleth/idp/plugin/authn/webauthn/css/webauthn.css
+++ b/webauthn-impl/src/main/resources/net/shibboleth/idp/plugin/authn/webauthn/css/webauthn.css
@@ -89,5 +89,5 @@ tr:hover {
 
 .authenticator-logo {
     vertical-align: middle;
-    max-width:20%;
+    max-width:2em;
 }
\ No newline at end of file
diff --git a/webauthn-impl/src/main/resources/net/shibboleth/idp/plugin/authn/webauthn/views/webauthn-register.vm b/webauthn-impl/src/main/resources/net/shibboleth/idp/plugin/authn/webauthn/views/webauthn-register.vm
index 3c7c8ea..d62af3b 100644
--- a/webauthn-impl/src/main/resources/net/shibboleth/idp/plugin/authn/webauthn/views/webauthn-register.vm
+++ b/webauthn-impl/src/main/resources/net/shibboleth/idp/plugin/authn/webauthn/views/webauthn-register.vm
@@ -127,8 +127,8 @@ $response.addHeader("Content-Security-Policy", "default-src 'none'; style-src 's
                          <table>
                             <tr>
                                <th>#springMessageText("idp.webauthn.register.table.header.keyName", "Key Name")</th>
+                               <th>#springMessageText("idp.webauthn.register.table.header.authenticatorIcon", "Icon")</th> 
                                <th>#springMessageText("idp.webauthn.register.table.header.authenticatorDescription", "Authenticator")</th>
-                               <th>#springMessageText("idp.webauthn.register.table.header.transports", "Transports")</th>
                                <th>#springMessageText("idp.webauthn.register.table.header.passkey", "Passkey?")</th>
                                <th>#springMessageText("idp.webauthn.register.table.header.registrationTime", "Registration Time")</th>
                                <th>#springMessageText("idp.webauthn.register.table.header.action", "Action")</th>
@@ -136,16 +136,16 @@ $response.addHeader("Content-Security-Policy", "default-src 'none'; style-src 's
                             #foreach($cred in $webauthnRegContext.existingCredentials)
                             <tr>
                                <td>$encoder.encodeForHTML($cred.credentialRegistration.nickname)</td>
+                               #if ($cred.icon)
+                                    <td> <img class="authenticator-logo" src="$encoder.encodeForHTML($cred.icon)" alt="authenticator-icon"/></td> 
+                               #else
+                                    <td></td>
+                               #end
                                #if ($cred.authenticatorDescription)
-                                   <td>
-                                   #if ($cred.icon)
-                                        <img class="authenticator-logo" src="$encoder.encodeForHTML($cred.icon)" alt="authenticator-icon"/> 
-                                   #end 
-                                   $encoder.encodeForHTML($cred.authenticatorDescription)</td>
+                                   <td>$encoder.encodeForHTML($cred.authenticatorDescription)</td>
                                #else
                                     <td>#springMessageText("idp.webauthn.register.table.unknownCredential", "unknown")</td>
                                #end
-                               <td>$encoder.encodeForHTML($webAuthnEncoder.formatTransports($cred.credentialRegistration.transports))</td>
                                <td>$encoder.encodeForHTML($webAuthnEncoder.formatDiscoverable($cred.credentialRegistration.isDiscoverable()))</td>
                                <td>$encoder.encodeForHTML($webAuthnEncoder.formatInstant($cred.credentialRegistration.registrationTime))</td>
                                <td>

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.