[java-idp-plugin-duo] branch dev/JDUO-80 updated: Adjust some property names and fix warnings.

Scott Cantor cantor.2 at osu.edu
Wed Jan 3 18:11:56 UTC 2024


This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch dev/JDUO-80
in repository java-idp-plugin-duo.

View the commit online:
http://git.shibboleth.net/view/?p=java-idp-plugin-duo.git;a=commit;h=5dd0d3d79fc8b4b5e98fae4a49009e529b263612

The following commit(s) were added to refs/heads/dev/JDUO-80 by this push:
     new 5dd0d3d7 Adjust some property names and fix warnings.
5dd0d3d7 is described below

commit 5dd0d3d79fc8b4b5e98fae4a49009e529b263612
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Wed Jan 3 13:11:53 2024 -0500

    Adjust some property names and fix warnings.
---
 .../net/shibboleth/idp/plugin/authn/duo/DefaultDuoCleanupHook.java  | 6 +++++-
 .../net/shibboleth/idp/flows/authn/DuoOIDC/duo-oidc-authn-beans.xml | 2 +-
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/idp-duo-api/src/main/java/net/shibboleth/idp/plugin/authn/duo/DefaultDuoCleanupHook.java b/idp-duo-api/src/main/java/net/shibboleth/idp/plugin/authn/duo/DefaultDuoCleanupHook.java
index 365147a8..0e12bbc3 100644
--- a/idp-duo-api/src/main/java/net/shibboleth/idp/plugin/authn/duo/DefaultDuoCleanupHook.java
+++ b/idp-duo-api/src/main/java/net/shibboleth/idp/plugin/authn/duo/DefaultDuoCleanupHook.java
@@ -107,6 +107,7 @@ public class DefaultDuoCleanupHook extends AbstractInitializableComponent implem
         removePasswordlessContext = flag;
     }
     
+// Checkstyle: CyclomaticComplexity OFF
     /** {@inheritDoc} */
     public void accept(@Nullable final ProfileRequestContext input) {
         checkComponentActive();
@@ -136,7 +137,8 @@ public class DefaultDuoCleanupHook extends AbstractInitializableComponent implem
                             assert dataSealer != null;
                             wrapped = dataSealer.wrap(wrapped);
                             assert cookieManager != null;
-                            cookieManager.addCookie(localCookieName, UrlEscapers.urlFormParameterEscaper().escape(wrapped));
+                            cookieManager.addCookie(localCookieName,
+                                    UrlEscapers.urlFormParameterEscaper().escape(wrapped));
                         } catch (final DataSealerException e) {
                             wrapped = null;
                             log.warn("Error sealing username cookie", e);
@@ -148,5 +150,7 @@ public class DefaultDuoCleanupHook extends AbstractInitializableComponent implem
             }
         }
     }
+// Checkstyle: CyclomaticComplexity ON
+    
 
 }
\ No newline at end of file
diff --git a/idp-duo-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/authn/DuoOIDC/duo-oidc-authn-beans.xml b/idp-duo-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/authn/DuoOIDC/duo-oidc-authn-beans.xml
index e0891e07..8c0586e3 100644
--- a/idp-duo-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/authn/DuoOIDC/duo-oidc-authn-beans.xml
+++ b/idp-duo-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/authn/DuoOIDC/duo-oidc-authn-beans.xml
@@ -149,7 +149,7 @@
         p:cookieManager="#{'%{idp.authn.usernameCookieName:}'.trim().isEmpty() ? null : getObject('shibboleth.PersistentCookieManager')}"
         p:cookieName="%{idp.authn.usernameCookieName:}"
         p:usernameFieldName="#{'%{idp.authn.DuoOIDC.usernameFieldName:j_username}'.trim()}"
-        p:checkSession="%{idp.authn.DuoOIDC.usernameFromSession:false}"
+        p:checkSession="%{idp.authn.usernameFromSession:false}"
         p:lowercase="%{idp.authn.DuoOIDC.lowercase:false}"
         p:uppercase="%{idp.authn.DuoOIDC.uppercase:false}"
         p:trim="%{idp.authn.Password.trim:true}"

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list