[java-idp-oidc] branch main updated: Fix some red/yellow issues in source.

[Scott Cantor]

This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch main
in repository java-idp-oidc.

View the commit online:
http://git.shibboleth.net/view/?p=java-idp-oidc.git;a=commit;h=c1257831e7f6d2e9373e6af327d9ad27e2c3d760

The following commit(s) were added to refs/heads/main by this push:
     new c1257831 Fix some red/yellow issues in source.
c1257831 is described below

commit c1257831e7f6d2e9373e6af327d9ad27e2c3d760
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Wed Jan 3 12:28:35 2024 -0500

    Fix some red/yellow issues in source.
---
 .../messaging/impl/FrontChannelLogoutPropagationResponse.java | 10 +++++-----
 .../oidc/op/messaging/impl/RpInitiatedLogoutResponse.java     | 11 +++++------
 2 files changed, 10 insertions(+), 11 deletions(-)

diff --git a/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/messaging/impl/FrontChannelLogoutPropagationResponse.java b/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/messaging/impl/FrontChannelLogoutPropagationResponse.java
index 1e928135..52e9d3db 100644
--- a/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/messaging/impl/FrontChannelLogoutPropagationResponse.java
+++ b/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/messaging/impl/FrontChannelLogoutPropagationResponse.java
@@ -23,13 +23,13 @@ import javax.annotation.Nonnull;
 import javax.annotation.Nullable;
 
 import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
 
 import com.nimbusds.oauth2.sdk.Response;
 import com.nimbusds.oauth2.sdk.http.HTTPResponse;
 
 import net.shibboleth.shared.logic.Constraint;
 import net.shibboleth.shared.logic.ConstraintViolationException;
+import net.shibboleth.shared.primitive.LoggerFactory;
 import net.shibboleth.shared.primitive.StringSupport;
 
 /**
@@ -42,13 +42,13 @@ public class FrontChannelLogoutPropagationResponse implements Response {
     @Nonnull private final Logger log = LoggerFactory.getLogger(FrontChannelLogoutPropagationResponse.class);
 
     /** The front-channel logout endpoint. */
-    @Nonnull final String frontChannelLogoutUri;
+    @Nonnull private final String frontChannelLogoutUri;
 
     /** The optional issuer (iss-parameter) value. */
-    @Nullable final String issuer;
+    @Nullable private final String issuer;
 
     /** The optional sessionId (sid-parameter) value. */
-    @Nullable final String sessionId;
+    @Nullable private final String sessionId;
 
     /**
      * Constructor.
@@ -112,7 +112,7 @@ public class FrontChannelLogoutPropagationResponse implements Response {
                 uri = new URI(frontChannelLogoutUri);
             }
             response.setLocation(uri);
-        } catch (@Nonnull final URISyntaxException | UnsupportedEncodingException e) {
+        } catch (final URISyntaxException | UnsupportedEncodingException e) {
             log.error("Could not construct an URI object", e);
         }
         return response;
diff --git a/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/messaging/impl/RpInitiatedLogoutResponse.java b/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/messaging/impl/RpInitiatedLogoutResponse.java
index 97bbd3a3..02bf25e8 100644
--- a/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/messaging/impl/RpInitiatedLogoutResponse.java
+++ b/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/messaging/impl/RpInitiatedLogoutResponse.java
@@ -23,11 +23,11 @@ import javax.annotation.Nonnull;
 import javax.annotation.Nullable;
 
 import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
 
 import com.nimbusds.oauth2.sdk.Response;
 import com.nimbusds.oauth2.sdk.http.HTTPResponse;
 
+import net.shibboleth.shared.primitive.LoggerFactory;
 import net.shibboleth.shared.primitive.StringSupport;
 
 /**
@@ -40,10 +40,10 @@ public class RpInitiatedLogoutResponse implements Response {
     @Nonnull private final Logger log = LoggerFactory.getLogger(RpInitiatedLogoutResponse.class);
 
     /** The post front-channel logout redirection endpoint. */
-    @Nullable final String postLogoutRedirectionUri;
+    @Nullable private final String postLogoutRedirectionUri;
 
     /** The optional state value. */
-    @Nullable final String state;
+    @Nullable private final String state;
 
     /**
      * Constructor.
@@ -65,7 +65,7 @@ public class RpInitiatedLogoutResponse implements Response {
         state = StringSupport.trimOrNull(relayState);
     }
 
-    @Override
+    /** {@inheritDoc} */
     public boolean indicatesSuccess() {
         return true;
     }
@@ -86,7 +86,6 @@ public class RpInitiatedLogoutResponse implements Response {
      *
      * @return An HTTP response for this message.
      */
-    @Override
     public HTTPResponse toHTTPResponse() {
 
         if (postLogoutRedirectionUri == null) {
@@ -106,7 +105,7 @@ public class RpInitiatedLogoutResponse implements Response {
                 uri = new URI(postLogoutRedirectionUri);
             }
             response.setLocation(uri);
-        } catch (@Nonnull final URISyntaxException | UnsupportedEncodingException e) {
+        } catch (final URISyntaxException | UnsupportedEncodingException e) {
             log.error("Could not construct an URI object", e);
         }
         return response;

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.