[JIRA] (MDA-208) XMLSignatureSigningStage.ShaVariant should be SHAVariant

Ian Young (Jira) jira at shibboleth.atlassian.net
Thu May 25 16:28:06 UTC 2023


Ian Young ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae127cb03-43ed-473d-b6ba-592949cb4be8 ) *commented* on MDA-208 ( https://shibboleth.atlassian.net/browse/MDA-208?atlOrigin=eyJpIjoiOTYxNTY2MjY1NjQ0NDU0N2JmMTI2YTEyZmU1ODEwOWQiLCJwIjoiaiJ9 )

Re: XMLSignatureSigningStage.ShaVariant should be SHAVariant ( https://shibboleth.atlassian.net/browse/MDA-208?atlOrigin=eyJpIjoiOTYxNTY2MjY1NjQ0NDU0N2JmMTI2YTEyZmU1ODEwOWQiLCJwIjoiaiJ9 )

I was hoping to provide some migration assistance, but even on a case-sensitive file system, the compiler claims there’s a classfile collision between ShaVariant and SHAVariant. So this ends up being a breaking change, one way or another. Given that, I don’t think there’s much value in providing migration assistance for the accessors, although that would be possible in principle.

( https://shibboleth.atlassian.net/browse/MDA-208#add-comment?atlOrigin=eyJpIjoiOTYxNTY2MjY1NjQ0NDU0N2JmMTI2YTEyZmU1ODEwOWQiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/MDA-208#add-comment?atlOrigin=eyJpIjoiOTYxNTY2MjY1NjQ0NDU0N2JmMTI2YTEyZmU1ODEwOWQiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100225- sha1:0428b75 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230525/e6171b2e/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-d7912e39-fb42-4e61-879c-cbb40472c096
Type: image/png
Size: 457 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230525/e6171b2e/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-d26f457a-4978-4ef6-a0bd-95f40e545129
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230525/e6171b2e/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-460d0fb2-e8f2-4bc2-831a-2dfedcc21cb2
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230525/e6171b2e/attachment-0005.png>


More information about the commits mailing list