[JIRA] (MDA-208) XMLSignatureSigningStage.ShaVariant should be SHAVariant

[Ian Young (Jira)]

Ian Young ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae127cb03-43ed-473d-b6ba-592949cb4be8 ) *commented* on MDA-208 ( https://shibboleth.atlassian.net/browse/MDA-208?atlOrigin=eyJpIjoiZDc3ZDQ3YzhhNjYyNGRmZGE1ZWYxNTMwZGJhN2M0OWQiLCJwIjoiaiJ9 )

Re: XMLSignatureSigningStage.ShaVariant should be SHAVariant ( https://shibboleth.atlassian.net/browse/MDA-208?atlOrigin=eyJpIjoiZDc3ZDQ3YzhhNjYyNGRmZGE1ZWYxNTMwZGJhN2M0OWQiLCJwIjoiaiJ9 )

On the question of accessor names, the design patterns section of the original beans spec says:

> 
> 
> 
> *8.8 Capitalization of inferred names.*
> 
> 
> 
> When we use design patterns to infer a property or event name, we need to
> decide what rules to follow for capitalizing the inferred name. If we
> extract the name from the middle of a normal mixedCase style Java name
> then the name will, by default, begin with a capital letter.
> 
> 
> 
> Java programmers are accustomed to having normal identifiers start with
> lower case letters. Vigorous reviewer input has convinced us that we
> should follow this same conventional rule for property and event names.
> 
> 
> 
> Thus when we extract a property or event name from the middle of an
> existing Java name, we normally convert the first character to lower case.
> However to support the occasional use of all upper-case names, we check if
> the first two characters of the name are both upper case and if so leave
> it alone. So for example,
> 
> 
> 
> “FooBah” becomes “fooBah” “Z” becomes “z”
> “URL” becomes “URL”
> 
> 
> 
> We provide a method Introspector.decapitalize which implements this
> conversion rule.
> 
> 

I think this means that the normal rules will work fine with, e.g., getSHAVariant inferring a property name of SHAVariant which is appropriately capitalised. I need to check that Spring does the right thing too, though.

There’s no need for the corresponding field to change, as it’s just an internal implementation detail. It can continue as shaVariant as before.

( https://shibboleth.atlassian.net/browse/MDA-208#add-comment?atlOrigin=eyJpIjoiZDc3ZDQ3YzhhNjYyNGRmZGE1ZWYxNTMwZGJhN2M0OWQiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/MDA-208#add-comment?atlOrigin=eyJpIjoiZDc3ZDQ3YzhhNjYyNGRmZGE1ZWYxNTMwZGJhN2M0OWQiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100225- sha1:0428b75 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230525/e339633c/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-75dd28cf-f142-461a-b358-cfc55b53934f
Type: image/png
Size: 457 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230525/e339633c/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-d1e0e4fe-0bf6-4a4d-85d0-946a109fe033
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230525/e339633c/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-5c95f9f9-fd49-44e2-8be0-c4010206c499
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230525/e339633c/attachment-0005.png>