[JIRA] (OSJ-380) Logging of assertion validation is overwriting specific error messages

[Scott Cantor (Jira)]

Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) *resolved* as *Fixed*

Since we can, I just went ahead and altered the ValidationContext API to expose a collection getter to add messages to in place of the get/set singleton.

I changed all the code calling it to add messages, and changed the messages to match the existing log messages better for detail, and then removed all duplicate logging.

The ValidateAssertions action now just logs the whole collection of messages in one go, and that comes out pretty cleanly with good context for what went wrong. Tested this on the address mismatch error and got out what I wanted.

OpenSAML - Java ( https://shibboleth.atlassian.net/browse/OSJ?atlOrigin=eyJpIjoiYzM3ZjlmNjc0YTY2NGNhZjkzMTIyYmE4ZGY2NTUyOTAiLCJwIjoiaiJ9 ) / Bug ( https://shibboleth.atlassian.net/browse/OSJ-380?atlOrigin=eyJpIjoiYzM3ZjlmNjc0YTY2NGNhZjkzMTIyYmE4ZGY2NTUyOTAiLCJwIjoiaiJ9 ) OSJ-380 ( https://shibboleth.atlassian.net/browse/OSJ-380?atlOrigin=eyJpIjoiYzM3ZjlmNjc0YTY2NGNhZjkzMTIyYmE4ZGY2NTUyOTAiLCJwIjoiaiJ9 ) Logging of assertion validation is overwriting specific error messages ( https://shibboleth.atlassian.net/browse/OSJ-380?atlOrigin=eyJpIjoiYzM3ZjlmNjc0YTY2NGNhZjkzMTIyYmE4ZGY2NTUyOTAiLCJwIjoiaiJ9 )

Change By: Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) Resolution: Fixed Status: Open Resolved

( https://shibboleth.atlassian.net/browse/OSJ-380#add-comment?atlOrigin=eyJpIjoiYzM3ZjlmNjc0YTY2NGNhZjkzMTIyYmE4ZGY2NTUyOTAiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/OSJ-380#add-comment?atlOrigin=eyJpIjoiYzM3ZjlmNjc0YTY2NGNhZjkzMTIyYmE4ZGY2NTUyOTAiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100225- sha1:d57183e )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230518/8b757d73/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-c28e1a38-e12b-481a-9afc-3c1d0a641b8b
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230518/8b757d73/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-b52a7971-e648-4a2e-9998-ae9a54d9816e
Type: image/png
Size: 345 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230518/8b757d73/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-597e2bf4-0482-4c57-bc65-4e43c8f7b7e3
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230518/8b757d73/attachment-0005.png>