[JIRA] (OSJ-380) Logging of assertion validation is overwriting specific error messages

[Scott Cantor (Jira)]

Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) *created* an issue

OpenSAML - Java ( https://shibboleth.atlassian.net/browse/OSJ?atlOrigin=eyJpIjoiMjlkMWU0YWI1MTQ1NDk5ZjljOWM4ZTFlNWI4OGQwYTciLCJwIjoiaiJ9 ) / Bug ( https://shibboleth.atlassian.net/browse/OSJ-380?atlOrigin=eyJpIjoiMjlkMWU0YWI1MTQ1NDk5ZjljOWM4ZTFlNWI4OGQwYTciLCJwIjoiaiJ9 ) OSJ-380 ( https://shibboleth.atlassian.net/browse/OSJ-380?atlOrigin=eyJpIjoiMjlkMWU0YWI1MTQ1NDk5ZjljOWM4ZTFlNWI4OGQwYTciLCJwIjoiaiJ9 ) Logging of assertion validation is overwriting specific error messages ( https://shibboleth.atlassian.net/browse/OSJ-380?atlOrigin=eyJpIjoiMjlkMWU0YWI1MTQ1NDk5ZjljOWM4ZTFlNWI4OGQwYTciLCJwIjoiaiJ9 )

Issue Type: Bug Affects Versions: 4.0.0, 4.0.1, 4.1.0, 4.1.1, 4.2.0 Assignee: Brent Putman ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A97de0981-adc3-4044-95ed-131622fad81e ) Components: SAML 2 Profiles Created: 18/May/23 10:19 AM Fix Versions: 5.0.0 Priority: Trivial Reporter: Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 )

The assertion validation code used to implement the proxying in the IdP seems to have some problems getting the specific cause of a failure logged properly. In at least one case, where it fails to validate SubjectConfirmations, it overwrites the original “cause” message in the ValidationContext with a generic one at the end of the loop saying “no methods were met”, so you never see the actual cause.

I think we meant to use INFO for this, because all the login methods tend to warn on INFO, but I suspect the best thing to do is to actually build up a collection of messages to eventually log at the end up in a higher layer.

I spotted some cases where the code checks for an existing message and appends it to a new one, but it’s simpler and more general to just let there be multiple.

( https://shibboleth.atlassian.net/browse/OSJ-380#add-comment?atlOrigin=eyJpIjoiMjlkMWU0YWI1MTQ1NDk5ZjljOWM4ZTFlNWI4OGQwYTciLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/OSJ-380#add-comment?atlOrigin=eyJpIjoiMjlkMWU0YWI1MTQ1NDk5ZjljOWM4ZTFlNWI4OGQwYTciLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100225- sha1:d57183e )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230518/89197173/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-d176d646-86a4-4eb4-b286-2eef6cfc0d4a
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230518/89197173/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-trivial-46dc4f06-6df9-4be9-b383-4afe6e84f389
Type: image/png
Size: 446 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230518/89197173/attachment-0005.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-04cd4a0d-f433-4167-9cf3-2a841dfb6891
Type: image/png
Size: 345 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230518/89197173/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-fea8ea0f-4ff8-4407-badf-5dea97f16dd0
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230518/89197173/attachment-0007.png>