[JIRA] (SSPCPP-973) ETag not being stored off when HTTP/2 used for metadata

[Scott Cantor (Jira)]

Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) *commented* on SSPCPP-973 ( https://shibboleth.atlassian.net/browse/SSPCPP-973?atlOrigin=eyJpIjoiZTE3ZmRjYjJmY2ZlNDg5OWEwYTE0MmE1YWZkZjEyM2MiLCJwIjoiaiJ9 )

Re: ETag not being stored off when HTTP/2 used for metadata ( https://shibboleth.atlassian.net/browse/SSPCPP-973?atlOrigin=eyJpIjoiZTE3ZmRjYjJmY2ZlNDg5OWEwYTE0MmE1YWZkZjEyM2MiLCJwIjoiaiJ9 )

Ah. Or it’s really simple.

if (strncmp(hdr, "ETag:", 5) == 0) {

That’s case-sensitive. Your headers are lower case. I am sure that’s probably in line with the HTTP spec that they’re case-insensitive, but if so that’s the bug. If by some miracle that’s not the case, then the server is either broken or curl’s translating is, but I suspect the RFC is clear about the case issue.

( https://shibboleth.atlassian.net/browse/SSPCPP-973#add-comment?atlOrigin=eyJpIjoiZTE3ZmRjYjJmY2ZlNDg5OWEwYTE0MmE1YWZkZjEyM2MiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/SSPCPP-973#add-comment?atlOrigin=eyJpIjoiZTE3ZmRjYjJmY2ZlNDg5OWEwYTE0MmE1YWZkZjEyM2MiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100219- sha1:6a6077b )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230328/a9a9eea6/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-311a06a7-ee5c-4d01-b5c5-75cf73d236a1
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230328/a9a9eea6/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-2288de51-119a-49c1-9e16-487a3387df6e
Type: image/png
Size: 345 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230328/a9a9eea6/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-ed072a03-6dd2-4f51-be59-1fca4e99130a
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230328/a9a9eea6/attachment-0005.png>