[JIRA] (JSSH-25) HTTPResource needs some rework to properly close response

Rod Widdowson (Jira) jira at shibboleth.atlassian.net
Mon Mar 20 13:39:03 UTC 2023


Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) *commented* on JSSH-25 ( https://shibboleth.atlassian.net/browse/JSSH-25?atlOrigin=eyJpIjoiNWMxZjQ1NmJlMTRjNDlmOGFkYjAzMjliOTgxZGNkNmIiLCJwIjoiaiJ9 )

Re: HTTPResource needs some rework to properly close response ( https://shibboleth.atlassian.net/browse/JSSH-25?atlOrigin=eyJpIjoiNWMxZjQ1NmJlMTRjNDlmOGFkYjAzMjliOTgxZGNkNmIiLCJwIjoiaiJ9 )

The feeling here is that the getInputStream is OK, but that there are holes where we do header inspection.

The basicModuleResource is another kettle of worms

( https://shibboleth.atlassian.net/browse/JSSH-25#add-comment?atlOrigin=eyJpIjoiNWMxZjQ1NmJlMTRjNDlmOGFkYjAzMjliOTgxZGNkNmIiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JSSH-25#add-comment?atlOrigin=eyJpIjoiNWMxZjQ1NmJlMTRjNDlmOGFkYjAzMjliOTgxZGNkNmIiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100218- sha1:fe49d35 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230320/6ac653c9/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-c80bb08c-2f62-48e3-b762-46f4b0eb508b
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230320/6ac653c9/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-4ecb20f1-91f3-42ad-a21d-a44fc51ba4c3
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230320/6ac653c9/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-350f2a7c-3907-4b0d-8a82-797081105e17
Type: image/png
Size: 484 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230320/6ac653c9/attachment-0005.png>


More information about the commits mailing list