[JIRA] (JSSH-25) HTTPResource needs some rework to properly close response

[Rod Widdowson (Jira)]

Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) *commented* on JSSH-25 ( https://shibboleth.atlassian.net/browse/JSSH-25?atlOrigin=eyJpIjoiOWQ3ZDAzYTkxN2QyNGRlZGE5NDliYzQ5OWIzYmI5MTgiLCJwIjoiaiJ9 )

Re: HTTPResource needs some rework to properly close response ( https://shibboleth.atlassian.net/browse/JSSH-25?atlOrigin=eyJpIjoiOWQ3ZDAzYTkxN2QyNGRlZGE5NDliYzQ5OWIzYmI5MTgiLCJwIjoiaiJ9 )

Unrelated and yet related

net.shibboleth.idp.module.AbstractIdPModule$BasicModuleResource#connect

Does something very weird with HttpClients

// The response socket should be closed after the stream is closed.final InputStream ret = response.getEntity().getContent();
               response = null;

( https://shibboleth.atlassian.net/browse/JSSH-25#add-comment?atlOrigin=eyJpIjoiOWQ3ZDAzYTkxN2QyNGRlZGE5NDliYzQ5OWIzYmI5MTgiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JSSH-25#add-comment?atlOrigin=eyJpIjoiOWQ3ZDAzYTkxN2QyNGRlZGE5NDliYzQ5OWIzYmI5MTgiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100217- sha1:2199b34 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230313/33cc3be9/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-cdc0e07d-f1b0-4bb2-b3d2-27b05d62c3c6
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230313/33cc3be9/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-6d0feeb6-b02c-4116-aa22-697b2963f374
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230313/33cc3be9/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-10f5a79e-508e-4527-884a-d8e81bee0dd8
Type: image/png
Size: 484 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230313/33cc3be9/attachment-0005.png>