[JIRA] (JCOMOIDC-66) Review ProfileConfiguration interfaces and concrete classes

[Scott Cantor (Jira)]

Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) *commented* on JCOMOIDC-66 ( https://shibboleth.atlassian.net/browse/JCOMOIDC-66?atlOrigin=eyJpIjoiZmJlMDBmM2I5MTRkNDY4YTk2OGU4ZWE1OGFiODM0ZjIiLCJwIjoiaiJ9 )

Re: Review ProfileConfiguration interfaces and concrete classes ( https://shibboleth.atlassian.net/browse/JCOMOIDC-66?atlOrigin=eyJpIjoiZmJlMDBmM2I5MTRkNDY4YTk2OGU4ZWE1OGFiODM0ZjIiLCJwIjoiaiJ9 )

It’s not a great idea. There are probably more settings related to things the RP does that may seem like they’re part of other profiles, but really they’re part of the RP’s behavior in supporting the SSO profile because it happens to use multiple endpoints at the other end.

They may not fit for the OP, which is why I suggested the refactoring to separate things a bit at least on the interfaces if not the underlying classes since they’re meant to be shared objects. Even if the class itself supports OP and RP settings, the actual interfaces don’t have to so the RP doesn’t ever interact with OP settings and vice versa.

( https://shibboleth.atlassian.net/browse/JCOMOIDC-66#add-comment?atlOrigin=eyJpIjoiZmJlMDBmM2I5MTRkNDY4YTk2OGU4ZWE1OGFiODM0ZjIiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JCOMOIDC-66#add-comment?atlOrigin=eyJpIjoiZmJlMDBmM2I5MTRkNDY4YTk2OGU4ZWE1OGFiODM0ZjIiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100217- sha1:fd7c927 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230315/107dfc5a/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-52715abe-cec2-4136-9386-3c358af5bb97
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230315/107dfc5a/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-c9c5c018-7f2d-4a5b-bdf4-bdd00d689569
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230315/107dfc5a/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-7bad5ff4-4f2f-4bbb-88e7-967e5b766f9e
Type: image/png
Size: 484 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230315/107dfc5a/attachment-0005.png>